imaffe commented on a change in pull request #18816:
URL: https://github.com/apache/flink/pull/18816#discussion_r808982242
##########
File path:
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/sink/writer/topic/TopicProducerRegister.java
##########
@@ -152,7 +156,7 @@ public void close() throws IOException {
builder.topic(topic);
Producer<T> producer = sneakyClient(builder::create);
producers.put(schemaInfo, producer);
-
+ pulsarSinkWriterMetrics.registerSingleProducerGauges(producer);
Review comment:
We can add producer metrics periodically in the timeService or we can
add the metrics register logic here. Not sure which one is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
