imaffe commented on a change in pull request #18816:
URL: https://github.com/apache/flink/pull/18816#discussion_r808976119
##########
File path:
flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/sink/writer/topic/TopicProducerRegisterTest.java
##########
@@ -76,7 +76,7 @@ void
noneAndAtLeastOnceWouldNotCreateTransaction(DeliveryGuarantee deliveryGuara
operator().createTopic(topic, 8);
SinkConfiguration configuration = sinkConfiguration(deliveryGuarantee);
- TopicProducerRegister register = new
TopicProducerRegister(configuration);
+ TopicProducerRegister register = new
TopicProducerRegister(configuration, null);
Review comment:
should not use null. Will throw NPE, use UnregisteredMetricsGroup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
