twalthr commented on a change in pull request #18770:
URL: https://github.com/apache/flink/pull/18770#discussion_r809875126
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ContextResolvedTableSerdeTest.java
##########
@@ -191,6 +176,24 @@ void withAnonymousTable() {
TableConfigOptions.CatalogPlanCompilation.IDENTIFIER,
TableConfigOptions.CatalogPlanRestore.IDENTIFIER);
+ @Test
+ void withAnonymousTable() throws Exception {
Review comment:
how about we move these tests for anonymous tables out of the nested
test structure to top-level test methods? anonymous tables have nothing to do
with the test matrix for catalog objects.
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java
##########
@@ -178,14 +178,18 @@ private TableConfigOptions() {}
+ "functions, or data types will be persisted
into the plan during "
+ "compilation. A schema allows for detecting
incompatible changes "
+ "in the catalog during a plan restore
operation. However, all "
- + "other metadata will still be retrieved from
the catalog.")),
+ + "other metadata will still be retrieved from
the catalog. "
+ + "This option does not apply to anonymous
tables, functions and data types, "
Review comment:
Move this to the option itself (not per enum value)? And also include
temporary objects for which this option has also no effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
