twalthr commented on a change in pull request #18770:
URL: https://github.com/apache/flink/pull/18770#discussion_r810902768
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ContextResolvedTableSerdeTest.java
##########
@@ -191,6 +176,24 @@ void withAnonymousTable() {
TableConfigOptions.CatalogPlanCompilation.IDENTIFIER,
TableConfigOptions.CatalogPlanRestore.IDENTIFIER);
+ @Test
+ void withAnonymousTable() throws Exception {
+ byte[] actualSerialized =
+
createObjectWriter(ctx).writeValueAsBytes(ANONYMOUS_CONTEXT_RESOLVED_TABLE);
+
+ assertThatThrownBy(
+ () ->
+ createObjectReader(ctx)
+ .readValue(
+ actualSerialized,
+
ContextResolvedTable.class))
+ .satisfies(
+ anyCauseMatches(
+ ValidationException.class,
+
ContextResolvedTableJsonDeserializer.missingIdentifier()
Review comment:
maybe there is still some misunderstanding, but why do we throw an
exception here? anonymous tables have nothing to do with the test matrix for
catalog objects, the given option should have no effect.
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java
##########
@@ -159,7 +159,15 @@ private TableConfigOptions() {}
// Enum option types
//
------------------------------------------------------------------------------------------
- /** Strategy to compile {@link Catalog} objects into a plan. */
+ /**
+ * Strategy to compile {@link Catalog} objects into a plan.
+ *
+ * <p>Depending on the configuration, permanent catalog metadata (such as
information about
Review comment:
Add this to the option description as well for the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
