[
https://issues.apache.org/jira/browse/FLINK-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420647#comment-15420647
]
ASF GitHub Bot commented on FLINK-4281:
---------------------------------------
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2372#discussion_r74723595
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkPlannerImpl.scala
---
@@ -68,12 +68,16 @@ class FlinkPlannerImpl(
}
}
- @throws(classOf[SqlParseException])
+ @throws(classOf[FlinkSqlParseException])
--- End diff --
Since **FlinkRelConversionException** is an unchecked exception, should we
add it to **throws**?
> Wrap all Calcite Exceptions in Flink Exceptions
> -----------------------------------------------
>
> Key: FLINK-4281
> URL: https://issues.apache.org/jira/browse/FLINK-4281
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Timo Walther
> Assignee: Jark Wu
>
> Some exceptions are already wrapped in Flink exceptions but there are still
> exceptions thrown by Calcite. I would propose that all Exceptions thrown by
> the Table API are Flink's Exceptions, esp. the FlinkPlannerImpl exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
