[
https://issues.apache.org/jira/browse/FLINK-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421075#comment-15421075
]
ASF GitHub Bot commented on FLINK-4281:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2372#discussion_r74771464
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/exceptions.scala
---
@@ -37,3 +37,16 @@ case class ValidationException(msg: String) extends
RuntimeException(msg)
* Exception for unwanted method calling on unresolved expression.
*/
case class UnresolvedException(msg: String) extends RuntimeException(msg)
+
+/**
+ * Exceptions for all errors occurring during sql parse phase
+ */
+case class FlinkSqlParseException(msg: String) extends
RuntimeException(msg)
--- End diff --
I think we should not include Flink in every class name.
`SqlParserException` would be better to be consistent with
`ExpressionParserException`.
> Wrap all Calcite Exceptions in Flink Exceptions
> -----------------------------------------------
>
> Key: FLINK-4281
> URL: https://issues.apache.org/jira/browse/FLINK-4281
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Timo Walther
> Assignee: Jark Wu
>
> Some exceptions are already wrapped in Flink exceptions but there are still
> exceptions thrown by Calcite. I would propose that all Exceptions thrown by
> the Table API are Flink's Exceptions, esp. the FlinkPlannerImpl exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
