slinkydeveloper commented on a change in pull request #18812:
URL: https://github.com/apache/flink/pull/18812#discussion_r810059418
##########
File path: docs/content/docs/dev/configuration/connector.md
##########
@@ -24,39 +24,42 @@ under the License.
# Connectors and Formats
-Flink can read from and write to various external systems via connectors and
define the format in
-which to store the data.
+Flink can read from and write to various external systems via connectors and
use the format of your choice
+in order to read/write data from/into records.
-The way that information is serialized is represented in the external system
and that system needs
Review comment:
If you want to add a quick sentence about formats, then you need a quick
one about connectors as well, right? Because the first sentence:
```
Flink can read from and write to various external systems via connectors and
use the format of your choice
in order to read/write data from/to records.
```
Already explains why you need connector and formats. So why adding another
sentence only to specify formats?
I don't think this reads nicely:
```
Flink can read from and write to various external systems via connectors and
use the format of your choice
in order to read/write data from/to records. Formats define how information
is encoded for storage.
Systems need to know how to read or write this data in a format that can be
understood by Flink.
```
Also because the way the second and third sentence is structured here is
that it first tells you the solution, then the problem. Perhaps what about:
```
Flink can read from and write to various external systems via connectors and
use the format of your choice
in order to read/write data from/to records. In order to connect to external
systems and read from and write to them, Flink needs connectors,
while in order to encode and decode data to Flink's data structures, Flink
needs format.
```
But then still the first sentence is kinda a summary of the second.
@MartijnVisser @matriv can you propose a wording up to the next sentence "an
overview of the available connectors[...]" ?
> Currently these formats are supported:
WDYM? i don't think we should list here what we support, as it's already in
the datastream/table api pages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
