infoverload commented on a change in pull request #18812:
URL: https://github.com/apache/flink/pull/18812#discussion_r810063601
##########
File path: docs/content/docs/dev/table/sourcesSinks.md
##########
@@ -113,19 +113,26 @@ Project Configuration
If you want to implement a custom connector or a custom format, the following
dependency is usually
sufficient:
-{{< artifact flink-table-common withProvidedScope >}}
+{{< artifact_tabs flink-table-common withProvidedScope >}}
If you want to develop a connector that needs to bridge with DataStream APIs
(i.e. if you want to adapt
a DataStream connector to the Table API), you need to add this dependency:
-{{< artifact flink-table-api-java-bridge withProvidedScope >}}
+{{< artifact_tabs flink-table-api-java-bridge withProvidedScope >}}
-When shipping the connector/format, we suggest providing both a thin JAR and
an uber JAR. This way,
-users can easily load the uber JAR in the SQL client or in the Flink
distribution and start using it.
+When developing the connector/format, we suggest shipping both a thin JAR and
an uber JAR.
+In particular, the uber JAR should include all the 3rd party dependencies of
the connector,
+excluding the table dependencies listed above.
Review comment:
```suggestion
In particular, the uber JAR should include all the third-party dependencies
of the connector,
excluding the table dependencies listed above.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
