[ 
https://issues.apache.org/jira/browse/FLINK-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420758#comment-15420758
 ] 

ASF GitHub Bot commented on FLINK-4081:
---------------------------------------

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/2297
  
    @StephanEwen I renamed `EMPTY_STRING` to `EMPTY_COLUMN`. All parsers that 
have a "format" (like Double, Boolean, Integer etc.) return `-1` and set 
`EMPTY_COLUMN`. The `StringParser` returns the String but sets `EMPTY_COLUMN` 
in case no quoting could be found.
    
    So in `..,12,,xyz,..` the column `,,` will always be set as `EMPTY_COLUMN` 
consistently across all parsers.


> FieldParsers should support empty strings
> -----------------------------------------
>
>                 Key: FLINK-4081
>                 URL: https://issues.apache.org/jira/browse/FLINK-4081
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>            Reporter: Flavio Pompermaier
>            Assignee: Timo Walther
>              Labels: csvparser, table-api
>
> In order to parse CSV files using the new Table API that converts rows to Row 
> objects (that support null values), FiledParser implementations should 
> support emptry strings setting the parser state to 
> ParseErrorState.EMPTY_STRING (for example FloatParser and DoubleParser 
> doesn't respect this constraint)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to