weibozhao commented on a change in pull request #60:
URL: https://github.com/apache/flink-ml/pull/60#discussion_r810859676



##########
File path: 
flink-ml-core/src/main/java/org/apache/flink/ml/util/ReadWriteUtils.java
##########
@@ -401,6 +383,19 @@ public static void updateExistingParams(Stage<?> stage, 
Map<Param<?>, Object> pa
         }
     }
 
+    /** Returns a subdirectory of the given path for saving/loading model 
data. */
+    private static String getDataPath(String path) {
+        return Paths.get(path, "data").toString();
+    }
+
+    /** Assigns model version for every model data when sinking to files. */
+    public static class ModelVersionAssigner<T> extends 
BasePathBucketAssigner<T> {

Review comment:
       OK




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to