twalthr commented on a change in pull request #18858:
URL: https://github.com/apache/flink/pull/18858#discussion_r811256759



##########
File path: 
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/utils/CatalogManagerMocks.java
##########
@@ -33,7 +35,15 @@
     public static final String DEFAULT_DATABASE = 
EnvironmentSettings.DEFAULT_BUILTIN_DATABASE;
 
     public static CatalogManager createEmptyCatalogManager() {
-        final CatalogManager catalogManager = preparedCatalogManager().build();
+        return createEmptyCatalogManager(null);
+    }
+
+    public static CatalogManager createEmptyCatalogManager(@Nullable Catalog 
catalog) {
+        final CatalogManager.Builder builder = preparedCatalogManager();
+        if (catalog != null) {

Review comment:
       The `preparedCatalogManager()` sets already a catalog, if the given one 
is null we use the default.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to