JingsongLi commented on a change in pull request #23:
URL: https://github.com/apache/flink-table-store/pull/23#discussion_r811741844
##########
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/FileStorePathFactory.java
##########
@@ -133,6 +133,9 @@ public Long latestSnapshotId() {
FileStatus[] statuses = fs.listStatus(snapshotDir);
long latestId = Snapshot.FIRST_SNAPSHOT_ID - 1;
+ if (statuses == null) {
+ return null;
+ }
Review comment:
I prefer to relax this restriction. read a non-existent table to return
an empty collection. It is not necessary for writer to create the `snapshot`
directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
