LadyForest commented on a change in pull request #23:
URL: https://github.com/apache/flink-table-store/pull/23#discussion_r811734958
##########
File path:
flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/sink/global/GlobalCommitterOperatorTest.java
##########
@@ -166,16 +166,33 @@ public void endOfInput() throws Exception {
assertThat(globalCommitter.getCommittedData()).contains("elder+patience+silent");
}
+ @Test
+ public void streamingNoEndOfInput() throws Exception {
+ final DefaultGlobalCommitter globalCommitter = new
DefaultGlobalCommitter();
+
+ final OneInputStreamOperatorTestHarness<CommittableMessage<String>,
Void> testHarness =
+ createTestHarness(globalCommitter, false);
+ testHarness.initializeEmptyState();
+ testHarness.open();
+ List<String> input = Arrays.asList("silent", "elder", "patience");
+ testHarness.processElements(committableRecords(input));
+ testHarness.endInput();
+ testHarness.close();
+ assertThat(globalCommitter.getCommittedData()).isEmpty();
Review comment:
Nit: line#150
`assertThat(globalCommitter.getCommittedData().isEmpty()).isTrue();` can be
shorten as `assertThat(globalCommitter.getCommittedData().isEmpty())`. Since
GitHub does not allow comments on unchanged lines, I post here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
