dannycranmer commented on a change in pull request #18876:
URL: https://github.com/apache/flink/pull/18876#discussion_r812054275
##########
File path:
flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java
##########
@@ -126,11 +126,7 @@ public void test() throws Exception {
generator.sinkTo(kdsSink);
env.execute("Integration Test");
- List<S3Object> objects =
- listBucketObjects(
- createS3Client(mockFirehoseContainer.getEndpoint(),
httpClient),
- BUCKET_NAME);
- assertThat(objects.size()).isEqualTo(NUMBER_OF_ELEMENTS);
+ List<S3Object> objects = listBucketObjects(s3AsyncClient, BUCKET_NAME);
Review comment:
Did we verify this is the cause of the test failure? Do we know why we
sometimes send duplicates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
