vahmed-hamdy commented on a change in pull request #18880:
URL: https://github.com/apache/flink/pull/18880#discussion_r812188588
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -229,6 +233,53 @@ public AsyncSinkWriter(
long maxBatchSizeInBytes,
long maxTimeInBufferMS,
long maxRecordSizeInBytes,
+ List<BufferedRequestState<RequestEntryT>> states) {
+ this(
+ elementConverter,
+ context,
+ maxBatchSize,
+ maxInFlightRequests,
+ maxBufferedRequests,
+ maxBatchSizeInBytes,
+ maxTimeInBufferMS,
+ maxRecordSizeInBytes,
+ new FixedRateLimitingStrategy(maxInFlightRequests *
maxBatchSize),
+ states);
+ }
+
+ public AsyncSinkWriter(
Review comment:
I agree, The multiple implementations of constructor are more confusing
than helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
