vahmed-hamdy commented on a change in pull request #18880: URL: https://github.com/apache/flink/pull/18880#discussion_r812207170
########## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/RateLimitingStrategy.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.base.sink.writer; + +import org.apache.flink.annotation.PublicEvolving; + +import java.io.Serializable; + +/** + * Strategy limiting inflight flow rate of written <b>messages</b> downstream by {@link + * AsyncSinkWriter}, Strategy should increase limit with each acknowledged/successful request and + * decrease limit with each throttled request. It is the writer responsibility to classify failed + * requests into throttled requests or any other failure. + */ +@PublicEvolving +public interface RateLimitingStrategy extends Serializable { + int getInFlightMessagesLimit(); Review comment: I agree,I intended to clarify that the class is for specific usage in the writer not a general one. The class however is not hardly coupled to the writer, I would change the interface signatures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
