twalthr commented on a change in pull request #18858:
URL: https://github.com/apache/flink/pull/18858#discussion_r812640476
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexNodeSerdeTest.java
##########
@@ -92,121 +519,129 @@ public void testRexNodeSerde(RexNode rexNode) throws
IOException {
Arrays.asList("f1", "f2", "f3"));
return Stream.of(
-
rexBuilder.makeNullLiteral(FACTORY.createSqlType(SqlTypeName.VARCHAR)),
- rexBuilder.makeLiteral(true),
- rexBuilder.makeExactLiteral(
- new BigDecimal(Byte.MAX_VALUE),
FACTORY.createSqlType(SqlTypeName.TINYINT)),
- rexBuilder.makeExactLiteral(
- new BigDecimal(Short.MAX_VALUE),
- FACTORY.createSqlType(SqlTypeName.SMALLINT)),
- rexBuilder.makeExactLiteral(
- new BigDecimal(Integer.MAX_VALUE),
- FACTORY.createSqlType(SqlTypeName.INTEGER)),
- rexBuilder.makeExactLiteral(
- new BigDecimal(Long.MAX_VALUE),
FACTORY.createSqlType(SqlTypeName.BIGINT)),
- rexBuilder.makeExactLiteral(
- BigDecimal.valueOf(Double.MAX_VALUE),
- FACTORY.createSqlType(SqlTypeName.DOUBLE)),
- rexBuilder.makeApproxLiteral(
- BigDecimal.valueOf(Float.MAX_VALUE),
- FACTORY.createSqlType(SqlTypeName.FLOAT)),
- rexBuilder.makeExactLiteral(new
BigDecimal("23.1234567890123456789012345678")),
- rexBuilder.makeIntervalLiteral(
- BigDecimal.valueOf(100),
- new SqlIntervalQualifier(
- TimeUnit.YEAR,
- 4,
- TimeUnit.YEAR,
- RelDataType.PRECISION_NOT_SPECIFIED,
- SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- BigDecimal.valueOf(3),
- new SqlIntervalQualifier(
- TimeUnit.YEAR,
- 2,
- TimeUnit.MONTH,
- RelDataType.PRECISION_NOT_SPECIFIED,
- SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- BigDecimal.valueOf(3),
- new SqlIntervalQualifier(
- TimeUnit.DAY, 2, TimeUnit.SECOND, 6,
SqlParserPos.ZERO)),
- rexBuilder.makeIntervalLiteral(
- BigDecimal.valueOf(3),
- new SqlIntervalQualifier(
- TimeUnit.SECOND, 2, TimeUnit.SECOND, 6,
SqlParserPos.ZERO)),
- rexBuilder.makeDateLiteral(DateString.fromDaysSinceEpoch(10)),
- rexBuilder.makeDateLiteral(new DateString("2000-12-12")),
- rexBuilder.makeTimeLiteral(TimeString.fromMillisOfDay(1234),
3),
- rexBuilder.makeTimeLiteral(TimeString.fromMillisOfDay(123456),
6),
- rexBuilder.makeTimeLiteral(new
TimeString("01:01:01.000000001"), 9),
-
rexBuilder.makeTimestampLiteral(TimestampString.fromMillisSinceEpoch(1234), 3),
-
rexBuilder.makeTimestampLiteral(TimestampString.fromMillisSinceEpoch(123456789),
9),
- rexBuilder.makeTimestampLiteral(
- new TimestampString("0001-01-01 01:01:01.000000001"),
9),
- rexBuilder.makeTimestampLiteral(new
TimestampString("2000-12-12 12:30:57.1234"), 4),
- rexBuilder.makeBinaryLiteral(ByteString.EMPTY),
-
rexBuilder.makeBinaryLiteral(ByteString.ofBase64("SGVsbG8gV29ybGQh")),
- rexBuilder.makeLiteral(""),
- rexBuilder.makeLiteral("abc"),
- rexBuilder.makeFlag(SqlTrimFunction.Flag.BOTH),
- rexBuilder.makeFlag(TimeUnitRange.DAY),
- rexBuilder.makeLiteral(
- Arrays.<Object>asList(1, 2L),
- FACTORY.createStructType(
- StructKind.PEEK_FIELDS_NO_EXPAND,
- Arrays.asList(
-
FACTORY.createSqlType(SqlTypeName.INTEGER),
-
FACTORY.createSqlType(SqlTypeName.BIGINT)),
- Arrays.asList("f1", "f2")),
- false),
- rexBuilder.makeSearchArgumentLiteral(
- Sarg.of(
- false,
- ImmutableRangeSet.of(
- Range.closed(
- BigDecimal.valueOf(1),
BigDecimal.valueOf(10)))),
- FACTORY.createSqlType(SqlTypeName.INTEGER)),
- rexBuilder.makeSearchArgumentLiteral(
- Sarg.of(
- false,
- ImmutableRangeSet.of(
- Range.range(
- BigDecimal.valueOf(1),
- BoundType.OPEN,
- BigDecimal.valueOf(10),
- BoundType.CLOSED))),
- FACTORY.createSqlType(SqlTypeName.INTEGER)),
- rexBuilder.makeSearchArgumentLiteral(
- Sarg.of(
- false,
- TreeRangeSet.create(
- Arrays.asList(
- Range.closed(
- BigDecimal.valueOf(1),
- BigDecimal.valueOf(1)),
- Range.closed(
- BigDecimal.valueOf(3),
- BigDecimal.valueOf(3)),
- Range.closed(
- BigDecimal.valueOf(6),
-
BigDecimal.valueOf(6))))),
- FACTORY.createSqlType(SqlTypeName.INTEGER)),
-
rexBuilder.makeInputRef(FACTORY.createSqlType(SqlTypeName.BIGINT), 0),
- rexBuilder.makeCorrel(inputType, new CorrelationId("$cor1")),
- rexBuilder.makeFieldAccess(
- rexBuilder.makeCorrel(inputType, new
CorrelationId("$cor2")), "f2", true),
- // cast($1 as smallint)
- rexBuilder.makeCast(
- FACTORY.createSqlType(SqlTypeName.SMALLINT),
-
rexBuilder.makeInputRef(FACTORY.createSqlType(SqlTypeName.INTEGER), 1)),
- // $1 in (1, 3, 5)
- rexBuilder.makeIn(
-
rexBuilder.makeInputRef(FACTORY.createSqlType(SqlTypeName.INTEGER), 1),
- Arrays.asList(
- rexBuilder.makeExactLiteral(new BigDecimal(1)),
- rexBuilder.makeExactLiteral(new BigDecimal(3)),
- rexBuilder.makeExactLiteral(new
BigDecimal(5)))),
+ //
Review comment:
that was a mistake and got removed in following commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
