twalthr commented on a change in pull request #18858:
URL: https://github.com/apache/flink/pull/18858#discussion_r812626974
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinition.java
##########
@@ -177,8 +177,9 @@ public String toString() {
// Shared with BuiltInSqlOperator and BuiltInSqlFunction in planner
//
--------------------------------------------------------------------------------------------
+ // note that for SQL operators the name can contain spaces and dollar signs
private static final Pattern INTERNAL_NAME_PATTERN =
- Pattern.compile("\\$[A-Z0-9_]+\\$[1-9][0-9]*");
+ Pattern.compile("\\$[A-Z0-9_ $]+\\$[1-9][0-9]*");
Review comment:
I neither want to support tabs nor newlines. Only spaces such as for `IS
NULL`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
