fapaul commented on pull request #18880:
URL: https://github.com/apache/flink/pull/18880#issuecomment-1048851610


   > I discussed this with @fapaul and we agreed that we can merge this change 
as a bug fix if we do not modify any public API. Therefore instead of adding 
the rate limiter to the concrete KDF/KDS implementation we will add it directly 
to the `AsyncSinkWriter`. We will follow up in Flink 1.16 with a FLIP to 
consolidate the feature and refactor at this point.
   
   Thanks for the detailed analysis and everyone working on this PR. The idea 
with the automatic buffer size calculations sounds definitely great. 
Unfortunately, we have to postpone the general availability of configurations a 
bit to avoid breaking APIs.
   Let's work together in 1.16 to roll this out in a configurable way.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to