austince commented on a change in pull request #303:
URL: https://github.com/apache/flink-statefun/pull/303#discussion_r813133655
##########
File path: statefun-sdk-go/v3/pkg/statefun/context.go
##########
@@ -76,6 +81,12 @@ func (s *statefunContext) Storage() AddressScopedStorage {
return s.storage
}
+func (s *statefunContext) WithContext(ctx context.Context) Context {
+ newContext := *s
+ newContext.Context = ctx
+ return &newContext
Review comment:
Ah yeah, I was thinking we want this to be a full, independent copy of
the Context, without shared state (like in `http.Request`). I don't have enough
"context" here to know if that's a requirement / what possible situations would
arise if the state is shared.
And yeah, agreed that the assignment will shallow copy all fields, just
curious about the pointer fields as they'd be shared state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
