galenwarren edited a comment on pull request #303: URL: https://github.com/apache/flink-statefun/pull/303#issuecomment-1049137119
I decided to answer my own question and go ahead and change to use a top-level function, in https://github.com/apache/flink-statefun/pull/303/commits/5d2360c03c5a020fb06c0f78f1f1bbef8318d502. Honestly, it's really no more or less clean to use, now a call looks like: ``` newContext := DeriveContext(originalContext, context.WithValue(originalContext, contextKey, contextValue)) ``` ... which seems fine. So, no concerns about breaking changes. @austince I should have followed your suggestion originally :). I'm open to suggestions on the name `DeriveContext`. EDIT: `WithContext` as a top-level function seemed a bit unclear to me, the `WithXXX` convention seemed more appropriate for methods with receivers than it did for a top-level function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
