afedulov opened a new pull request #18905:
URL: https://github.com/apache/flink/pull/18905
## What is the purpose of the change
`flink-connector-base` was previously inconsistently used in connectors
(directly shaded in some and transitively pulled in via `flink-connector-files`
which was itself shaded in the table uber jar). FLINK-24687 moved
`flink-connector-files` out from the `flink-table` uber jar. This commit
implements a combined approach for ensuring a smooth transition for both Flink
users and for external connector developers, as outlined in this :
- all internal Flink connectors that depend on `flink-connector-base` now
shade and relocate it
- for compatibility, until external developers implement the same change,
`flink-connector-base` is also included into `flink-dist`
with adds shading and relocation of `flink-connector-base` into all
connectors and packages
## Brief change log
- `flink-connector-base` dependency is excluded from shading in connectors
- `flink-connector-base` is packaged into Flink's `/lib` folder
- `flink-connector-base` is added in provided and/or test scopes where
needed
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: ( no )
- The serializer: ( no )
- The runtime per-record code paths (performance sensitive): ( no )
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
- The S3 file system connector: ( no )
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (release notes). The following
text was added to the tickets' release notes:
## Known issues:
Due to the setup of the newly added Kafka end-to-end tests, they became
incompatible with this change when executed in the IDE (unshaded classes from
IntelliJ modules get used in the `RemoteStreamEnvironment`). The testing
approach is due to be revisited in the next versions of Flink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
