matriv commented on a change in pull request #18872:
URL: https://github.com/apache/flink/pull/18872#discussion_r813973746
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexNodeJsonDeserializer.java
##########
@@ -317,8 +317,11 @@ private static RexNode deserializeCall(JsonNode jsonNode,
SerdeContext serdeCont
return serdeContext.getRexBuilder().makeCall(callType, operator,
rexOperands);
}
- private static SqlOperator deserializeSqlOperator(
- JsonNode jsonNode, SerdeContext serdeContext) {
+ //
--------------------------------------------------------------------------------------------
Review comment:
same here/
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ResolvedSchemaJsonSerializer.java
##########
@@ -28,14 +29,20 @@
import static
org.apache.flink.table.planner.plan.nodes.exec.serde.JsonSerdeUtil.serializeOptionalField;
-class ResolvedSchemaJsonSerializer extends StdSerializer<ResolvedSchema> {
+/**
+ * JSON serializer for {@link ResolvedSchema}.
+ *
+ * @see ResolvedSchema for the reverse operation
Review comment:
```suggestion
* @see ResolvedSchemaJsonDeserializer for the reverse operation
```
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexNodeJsonSerializer.java
##########
@@ -359,7 +359,11 @@ private static void serializeCall(
gen.writeEndObject();
}
- private static void serializeSqlOperator(
+ //
--------------------------------------------------------------------------------------------
+ // Logic shared with AggregateCallJsonSerializer
Review comment:
Why not a javadoc comment to use also `{@link }`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
