matriv commented on a change in pull request #18908:
URL: https://github.com/apache/flink/pull/18908#discussion_r814650131
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/delegation/PlannerContext.java
##########
@@ -105,6 +106,7 @@
public PlannerContext(
boolean isBatchMode,
+ ReadableConfig plannerConfig,
TableConfig tableConfig,
Review comment:
Unfortunately we still need it, there are still a few places that get it
from the context to use it in code generator classes.
I have an upcoming PR that cleans up everything that has to do with
plannerConfig/tableConfig, and I move a method from `FlinkOptRelUtil` to
`ShortcutUtils` so it's 100% visible where the tableConfig is still needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
