matriv commented on a change in pull request #18908:
URL: https://github.com/apache/flink/pull/18908#discussion_r814662369
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeConfig.java
##########
@@ -51,20 +51,20 @@
private final ReadableConfig nodeConfig;
ExecNodeConfig(
- ReadableConfig plannerConfig, TableConfig tableConfig,
ReadableConfig nodeConfig) {
+ ReadableConfig plannerConfig, TableConfig tableConfig,
ReadableConfig persistedConfig) {
Review comment:
`PlannerConfig` doesn't expose `TableConfig`, and currently we need
`TableConfig` to pass it from `ExecNodeConfig` (the merged configuration) to
the codegenerator, and also for the timezone and the calculation for the
deprecated `getMaxIdleStateRetentionTime`. I have linked to the issue to fix
that soon and remove the need for the `TableConfig` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
