dmvk commented on a change in pull request #18901:
URL: https://github.com/apache/flink/pull/18901#discussion_r815952658
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/persistence/TestingLongStateHandleHelper.java
##########
@@ -106,17 +114,26 @@ public long getValue() {
@Override
public void discardState() {
- preDiscardCallback.run(value);
-
- numberOfDiscardCalls++;
+ try {
+ preDiscardCallback.run(numberOfDiscardCalls);
+ numberOfSuccessfulDiscardCalls++;
+ } catch (Exception e) {
Review comment:
Just being explicit that this is primarily for the cases where we throw
an exception. Also I'm using checked exceptions in the test suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
