dmvk commented on a change in pull request #18901:
URL: https://github.com/apache/flink/pull/18901#discussion_r817458212
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesStateHandleStore.java
##########
@@ -469,7 +574,17 @@ public void releaseAndTryRemoveAll() throws Exception {
"Could not properly remove
all state handles.",
exception));
}
+ // Commit the "removal transaction" by
removing the entries from the
+ // ConfigMap.
+ return updateConfigMap(
Review comment:
This would be really inefficient with k8s implementation. At the end it
shouldn't make much of a difference as we're handling soft deletes as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
