twalthr commented on a change in pull request #18885:
URL: https://github.com/apache/flink/pull/18885#discussion_r816862870
##########
File path:
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/utils/PlannerMock.java
##########
@@ -50,12 +50,12 @@ public String explain(List<Operation> operations,
ExplainDetail... extraDetails)
}
@Override
- public CompiledPlan loadPlan(PlanReference planReference) throws
IOException {
+ public CompiledPlanInternalFactory loadPlan(PlanReference planReference)
throws IOException {
Review comment:
I think properly splitting API from internal `CompiledPlan` makes sense.
I was also thinking about this.
So:
- `CompiledPlan` = API
- `InternalPlan` = used for all `Planner` methods
Let's try to not use `CompiledPlanInternal` if it doesn't extend from
`CompiledPlan` anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
