twalthr commented on a change in pull request #18885:
URL: https://github.com/apache/flink/pull/18885#discussion_r816904314
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/delegation/InternalPlan.java
##########
@@ -16,19 +16,35 @@
* limitations under the License.
*/
-package org.apache.flink.table.api.internal;
+package org.apache.flink.table.delegation;
+import org.apache.flink.FlinkVersion;
import org.apache.flink.annotation.Internal;
import org.apache.flink.table.api.CompiledPlan;
+import org.apache.flink.table.api.TableEnvironment;
+import java.io.File;
import java.util.List;
/**
- * Internal interface of {@link CompiledPlan} containing methods used by {@link
- * TableEnvironmentInternal} implementation.
+ * Internal interface wrapping a plan. This is used in order to propagate the
plan back and forth
+ * the {@link Planner} interface. The {@link TableEnvironment} wraps it in an
implementation of
+ * {@link CompiledPlan}, to provide the fluent user-friendly interface.
*/
@Internal
-public interface CompiledPlanInternal extends CompiledPlan {
+public interface InternalPlan {
+
+ /** @see CompiledPlan#asJsonString() */
+ String asJsonString();
+
+ /**
+ * Note that {@code ignoreIfExists} has precedence over {@code
failIfExists}.
+ *
+ * @see CompiledPlan#writeToFile(File, boolean) */
Review comment:
this should let spotless fail, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
