bgeng777 commented on a change in pull request #18739:
URL: https://github.com/apache/flink/pull/18739#discussion_r817405111
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
##########
@@ -854,6 +855,25 @@ public void testGenerateApplicationMasterEnv() throws
IOException {
assertEquals(flinkHomeDir.getPath(),
masterEnv.get(YarnConfigKeys.ENV_CLIENT_HOME_DIR));
}
+ @Test
+ public void testEnvFlinkLibDirVarNotOverriddenBySystem() throws
IOException {
Review comment:
I checked YARN's relevant codes for
[nodemanager](https://github.com/apache/hadoop/blob/91997872155e4b4b99c3dea7baccddbf2af9aa19/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java)
and
[ApplicationMaster](https://github.com/apache/hadoop/blob/03cfc852791c14fad39db4e5b14104a276c08e59/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java#L199).
IIUC, the system env will be inherited by YARN's containers. So the system
env can take effects.
But I do agree that `CONTAINERIZED_MASTER_ENV_PREFIX` should be tested as
well. `ENV_FLINK_LIB_DIR` is an unmodifiable var in our Flink use case when
launching containers.
I will add the test for `CONTAINERIZED_MASTER_ENV_PREFIX` asap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
