bgeng777 commented on a change in pull request #18739:
URL: https://github.com/apache/flink/pull/18739#discussion_r817471176
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
##########
@@ -854,6 +855,25 @@ public void testGenerateApplicationMasterEnv() throws
IOException {
assertEquals(flinkHomeDir.getPath(),
masterEnv.get(YarnConfigKeys.ENV_CLIENT_HOME_DIR));
}
+ @Test
+ public void testEnvFlinkLibDirVarNotOverriddenBySystem() throws
IOException {
Review comment:
I see your point. I agree current test is useless as it is run in client
side. Using `CONTAINERIZED_MASTER_ENV_PREFIX` makes more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
