wangyang0918 commented on a change in pull request #18739:
URL: https://github.com/apache/flink/pull/18739#discussion_r817438292
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
##########
@@ -854,6 +855,25 @@ public void testGenerateApplicationMasterEnv() throws
IOException {
assertEquals(flinkHomeDir.getPath(),
masterEnv.get(YarnConfigKeys.ENV_CLIENT_HOME_DIR));
}
+ @Test
+ public void testEnvFlinkLibDirVarNotOverriddenBySystem() throws
IOException {
Review comment:
`YarnClusterDescriptor` is running on the client side. So I do not think
the current test make sense if you really want to test system env on the JM/TM
side should not override `ENV_FLINK_LIB_DIR`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
