wangyang0918 commented on a change in pull request #18739:
URL: https://github.com/apache/flink/pull/18739#discussion_r817387290
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
##########
@@ -854,6 +855,25 @@ public void testGenerateApplicationMasterEnv() throws
IOException {
assertEquals(flinkHomeDir.getPath(),
masterEnv.get(YarnConfigKeys.ENV_CLIENT_HOME_DIR));
}
+ @Test
+ public void testEnvFlinkLibDirVarNotOverriddenBySystem() throws
IOException {
Review comment:
I think what we need to test is `ENV_FLINK_LIB_DIR` is not overridden by
user specified envs via `CONTAINERIZED_MASTER_ENV_PREFIX`, not overridden by
system environment.
```
flinkConfig.setString(
ResourceManagerOptions.CONTAINERIZED_MASTER_ENV_PREFIX
+ ConfigConstants.ENV_FLINK_LIB_DIR,
"/path/of/flink-lib");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
