fapaul commented on a change in pull request #18825:
URL: https://github.com/apache/flink/pull/18825#discussion_r817738299
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java
##########
@@ -147,13 +147,18 @@ public void testIncreasingRecordBasedCounters() throws
Exception {
try (final KafkaWriter<Integer> writer =
createWriterWithConfiguration(
getKafkaClientConfiguration(), DeliveryGuarantee.NONE,
metricGroup)) {
- final Counter numBytesOut =
operatorIOMetricGroup.getNumBytesOutCounter();
- final Counter numRecordsOut =
operatorIOMetricGroup.getNumRecordsOutCounter();
- assertEquals(numBytesOut.getCount(), 0L);
+ final Counter numBytesSend = metricGroup.getNumBytesSendCounter();
+ final Counter numRecordsSend =
metricGroup.getNumRecordsSendCounter();
+ final Counter numRecordsWrittenErrors =
metricGroup.getNumRecordsOutErrorsCounter();
+ assertEquals(numBytesSend.getCount(), 0L);
Review comment:
Please use assertJ for new assertions `assertThat(...).isEqualTo()`
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java
##########
@@ -406,6 +409,7 @@ public WriterCallback(
@Override
public void onCompletion(RecordMetadata metadata, Exception exception)
{
if (exception != null) {
+ numRecordsOutErrorsCounter.inc();
Review comment:
This seems to be some sort of new feature. Can you add it on a separate
commit and a test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
