fapaul commented on a change in pull request #18825:
URL: https://github.com/apache/flink/pull/18825#discussion_r817786073
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java
##########
@@ -406,6 +409,7 @@ public WriterCallback(
@Override
public void onCompletion(RecordMetadata metadata, Exception exception)
{
if (exception != null) {
+ numRecordsOutErrorsCounter.inc();
Review comment:
One scenario that might work is that you create a second
`FlinkKafkaInternalProducer` to fence the writer.
So you would first write some records to kafka with the writer and before
calling `prepareCommit` create a FlinkKafkaInternalProducer that uses the same
transaction id to writes some records and commits. I suspect that now calling
`write` and `prepareCommit` on the writer lead to a `ProducerFencedException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
