fapaul commented on a change in pull request #18805:
URL: https://github.com/apache/flink/pull/18805#discussion_r819614300
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/SinkWriterOperator.java
##########
@@ -185,12 +219,36 @@ private void emitCommittables(Long checkpointId) throws
IOException, Interrupted
Collection<CommT> committables =
((PrecommittingSinkWriter<?, CommT>)
sinkWriter).prepareCommit();
StreamingRuntimeContext runtimeContext = getRuntimeContext();
- int indexOfThisSubtask = runtimeContext.getIndexOfThisSubtask();
+ final int indexOfThisSubtask = runtimeContext.getIndexOfThisSubtask();
+ final int numberOfParallelSubtasks =
runtimeContext.getNumberOfParallelSubtasks();
+
+ // Emit only committable summary if there are legacy committables
+ if (!legacyCommittables.isEmpty()) {
+ emit(
Review comment:
I guess it could be that the pipeline is started from a savepoint that
is `InitContext.INITIAL_CHECKPOINT_ID`. I think checking `checkpointId >=
InitContext.INITIAL_CHECKPOINT_ID` makes more sense. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
