fapaul commented on a change in pull request #18805:
URL: https://github.com/apache/flink/pull/18805#discussion_r819633484
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/SinkV1Adapter.java
##########
@@ -447,5 +451,13 @@ public void commit(Collection<CommitRequest<CommT>>
committables)
committables.forEach(CommitRequest::retryLater);
Review comment:
This is not easily possible because only committable are retriable at
this point. I would need to add a special logic when this happens. I rely here
on the fact that I assume all `commit` calls are idempotent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
