XComp opened a new pull request #18987:
URL: https://github.com/apache/flink/pull/18987


   ## What is the purpose of the change
   
   The retryable cleanup works but does not reveal the actual error which makes 
it harder to identify the error. This PR fixes it.
   
   ## Brief change log
   
   * `DefaultResourceCleaner.Builder` method signatures for adding cleanups are 
extended to also require a label that is passed. The label should be unique to 
make each cleanup identifyable in the logs.
   
   ## Verifying this change
   
   * A test was added to check the uniqueness of the label
   * The logging was verified manually by running the 
`DefaultResourceCleanerTest` methods with logging enabled
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? JavaDoc
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to