rkhachatryan commented on a change in pull request #18976:
URL: https://github.com/apache/flink/pull/18976#discussion_r820576190
##########
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogStorage.java
##########
@@ -72,14 +73,19 @@ public FsStateChangelogStorage(
ChangelogStorageMetricGroup metricGroup)
throws IOException {
this(
Review comment:
This constructor is used in another project -
`flink-statebackend-changelog` (class `ChangelogStateBackendTestUtils`).
Therefore, this change would require making `StateChangeFsUploader` class
public.
I think keeping `StateChangeFsUploader` class package-private is more
important than removing this constructor, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
