rkhachatryan commented on a change in pull request #18976:
URL: https://github.com/apache/flink/pull/18976#discussion_r821931818
##########
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFsUploader.java
##########
@@ -96,19 +91,20 @@ public void upload(Collection<UploadTask> tasks) throws
IOException {
closer.register(() -> fileSystem.delete(path, true));
}
}
+ return null; // closer above throws an exception
Review comment:
In that case, if a new exception will be thrown from e.g.
`fileSystem.delete`, then the original exception `e` will be lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
