[
https://issues.apache.org/jira/browse/FLINK-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426728#comment-15426728
]
ASF GitHub Bot commented on FLINK-4414:
---------------------------------------
Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/2381
Coming back to the initial motivation of this PR, It is because that I
tried to get the address from the RpcService, and the RpcService provides a api
`getAddress(RpcGateway gateway)` but can noly provide the address of endpoint
created on it only.
Another solution just for discuss:
1. change function prototype to `getAddress(RpcEndpoint endpoint)`
2. the AkkaRpcService can adapt this change easily, since we can get
actorRef from RpcEndpoint, and do what is done now. Besides, AkkaRpcService
need to check whether the actorRef is in the cached actors and raise a
exception if not.
In this way, we cannot get address from gateway, but it also make sense
since the endpoint is server , which must have a address to visit, and the
gateway is a client, providing an address is an optional.
> Remove restriction on RpcService.getAddress
> -------------------------------------------
>
> Key: FLINK-4414
> URL: https://issues.apache.org/jira/browse/FLINK-4414
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Wenlong Lyu
> Assignee: Wenlong Lyu
>
> currently {{RpcService}} provide only address of the endpoint, I think rpc
> service serve both the endpoint create on it and the remote gateway create on
> it, so it is ok to offer the getAddress to all {{RpcGateway}} created on the
> rpc service including the server and client.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
