[ 
https://issues.apache.org/jira/browse/FLINK-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427906#comment-15427906
 ] 

ASF GitHub Bot commented on FLINK-4414:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2381
  
    Hi @wenlong88,
    
    1. I'm actually not so sure whether `RpcGateway.getAddress` method is 
something framework specific. For any `RpcService` implementation you need some 
kind of address to connect to a `RpcEndpoint`. The `RpcService` has the method 
`connect` which requires exactly this information to open a connection. Thus, I 
think that every `RpcGateway` should be able to tell to which `RpcEndpoint` it 
is currently connected. So for example, there is currently also no way to open 
another `RpcGateway` to the same `RpcEndpoint` given a `RpcGateway`. What do 
you think?
    2. You're right, the current implementation has the same problem and should 
be fixed either way.


> Remove restriction on RpcService.getAddress
> -------------------------------------------
>
>                 Key: FLINK-4414
>                 URL: https://issues.apache.org/jira/browse/FLINK-4414
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Wenlong Lyu
>            Assignee: Wenlong Lyu
>
> currently {{RpcService}} provide only address of the endpoint, I think rpc 
> service serve both the endpoint create on it and the remote gateway create on 
> it, so it is ok to offer the getAddress to all {{RpcGateway}} created on the 
> rpc service including the server and client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to