zentol commented on a change in pull request #19039:
URL: https://github.com/apache/flink/pull/19039#discussion_r825865415
##########
File path:
flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/CatalogTest.java
##########
@@ -203,11 +197,12 @@ public void testAlterDb() throws Exception {
CatalogDatabase newDb = createAnotherDb();
catalog.alterDatabase(db1, newDb, false);
- assertFalse(
- catalog.getDatabase(db1)
- .getProperties()
- .entrySet()
- .containsAll(db.getProperties().entrySet()));
+ assertThat(
+ catalog.getDatabase(db1)
+ .getProperties()
+ .entrySet()
+ .containsAll(db.getProperties().entrySet()))
+ .isFalse();
Review comment:
What's the usual way to invert an assertion? Assume that we were
asserting `isTrue()`, then we'd want to use `containsAllEntriesOf`, but there
isn't a "`notContainsAllEntriesOf`" version (nor some generic notSatisfies).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
