zentol commented on a change in pull request #19039:
URL: https://github.com/apache/flink/pull/19039#discussion_r825900549
##########
File path:
flink-table/flink-table-common/src/test/java/org/apache/flink/table/data/columnar/vector/ColumnVectorTest.java
##########
@@ -351,16 +348,16 @@ public void testTimestamp() {
.toArray()));
setRangeDictIds(vector);
for (int i = 0; i < SIZE; i++) {
- assertEquals(TimestampData.fromEpochMillis(i, i),
vector.getTimestamp(i, 9));
+ assertThat(vector.getTimestamp(i,
9)).isEqualTo(TimestampData.fromEpochMillis(i, i));
}
}
@Test
public void testReserveDictIds() {
HeapIntVector vector = new HeapIntVector(SIZE);
- assertTrue(vector.reserveDictionaryIds(2).vector.length >= 2);
- assertTrue(vector.reserveDictionaryIds(5).vector.length >= 5);
- assertTrue(vector.reserveDictionaryIds(2).vector.length >= 2);
+
assertThat(vector.reserveDictionaryIds(2).vector.length).isGreaterThanOrEqualTo(2);
Review comment:
This _could_ use hasSizeGreaterThanOrEqualTo.
##########
File path:
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/multipleinput/TableOperatorWrapperTest.java
##########
@@ -51,26 +48,23 @@ public void testBasicInfo() {
wrapper3.addInput(wrapper1, 1);
wrapper3.addInput(wrapper2, 2);
- assertTrue(wrapper1.getInputEdges().isEmpty());
- assertTrue(wrapper1.getInputWrappers().isEmpty());
- assertEquals(Collections.singletonList(wrapper3),
wrapper1.getOutputWrappers());
- assertEquals(
- Collections.singletonList(new Edge(wrapper1, wrapper3, 1)),
- wrapper1.getOutputEdges());
-
- assertTrue(wrapper2.getInputEdges().isEmpty());
- assertTrue(wrapper2.getInputWrappers().isEmpty());
- assertEquals(Collections.singletonList(wrapper3),
wrapper2.getOutputWrappers());
- assertEquals(
- Collections.singletonList(new Edge(wrapper2, wrapper3, 2)),
- wrapper2.getOutputEdges());
-
- assertTrue(wrapper3.getOutputEdges().isEmpty());
- assertTrue(wrapper3.getOutputWrappers().isEmpty());
- assertEquals(Arrays.asList(wrapper1, wrapper2),
wrapper3.getInputWrappers());
- assertEquals(
- Arrays.asList(new Edge(wrapper1, wrapper3, 1), new
Edge(wrapper2, wrapper3, 2)),
- wrapper3.getInputEdges());
+ assertThat(wrapper1.getInputEdges().isEmpty()).isTrue();
+ assertThat(wrapper1.getInputWrappers().isEmpty()).isTrue();
+ assertThat(wrapper1.getOutputWrappers()).containsExactly(wrapper3);
+ assertThat(wrapper1.getOutputEdges()).containsExactly(new
Edge(wrapper1, wrapper3, 1));
+
+ assertThat(wrapper2.getInputEdges().isEmpty()).isTrue();
+ assertThat(wrapper2.getInputWrappers().isEmpty()).isTrue();
Review comment:
```suggestion
assertThat(wrapper2.getInputEdges()).isEmpty();
assertThat(wrapper2.getInputWrappers()).isEmpty();
```
hmm, I thought this migration worked already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
