slinkydeveloper commented on a change in pull request #19001:
URL: https://github.com/apache/flink/pull/19001#discussion_r826072070
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/LikeCallGen.scala
##########
@@ -109,16 +109,16 @@ class LikeCallGen extends CallGenerator {
val middleMatcher = MIDDLE_PATTERN.matcher(newPattern)
if (noneMatcher.matches()) {
- val reusePattern = ctx.addReusableStringConstants(newPattern)
+ val reusePattern =
ctx.addReusableEscapedStringConstant(newPattern)
Review comment:
The fact that is adding a constant is quite important, i wouldn't remove
it from the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
