slinkydeveloper commented on a change in pull request #19001:
URL: https://github.com/apache/flink/pull/19001#discussion_r826076814
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala
##########
@@ -464,19 +465,10 @@ class ExprCodeGenerator(ctx: CodeGeneratorContext,
nullableInput: Boolean)
override def visitCall(call: RexCall): GeneratedExpression = {
val resultType = FlinkTypeFactory.toLogicalType(call.getType)
if (call.getKind == SqlKind.SEARCH) {
Review comment:
We need this check because the `generateCallExpression` method accepts
the operands already converted to expressions. But in case of search, the
codegen uses `Sarg` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
