LadyForest commented on a change in pull request #41:
URL: https://github.com/apache/flink-table-store/pull/41#discussion_r826532696
##########
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStoreFactory.java
##########
@@ -84,14 +109,15 @@ public void onCreateTable(Context context, boolean
ignoreIfExists) {
context.getObjectIdentifier().asSerializableString()));
}
path.getFileSystem().mkdirs(path);
+ options.put(TABLE_PATH.key(), path.getPath());
Review comment:
I have some questions here.
1. If the users specify `table.path`, does it indicate `file.path` is
useless and can be simplified as one?
2. Let users specify the `table.path` means we lose control of the relative
table path/table name. We cannot reconstruct the relative path/table name
simply from `tableIdentifier`. If we give users this choice, do we also
consider let users name their topic freely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
