LadyForest commented on a change in pull request #41:
URL: https://github.com/apache/flink-table-store/pull/41#discussion_r826534273
##########
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStoreFactory.java
##########
@@ -84,14 +109,15 @@ public void onCreateTable(Context context, boolean
ignoreIfExists) {
context.getObjectIdentifier().asSerializableString()));
}
path.getFileSystem().mkdirs(path);
+ options.put(TABLE_PATH.key(), path.getPath());
Review comment:
> 1.I think we can enrich table path in the `enrichOptions`. 2.Maybe we
can support table path configuration from user. 3.`path.getPath` is wrong, it
lacks scheme, we should use `path.toString`.
I think we can enrich `table.path` in `enrichOptions`, but still keep this
option internal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
