fapaul commented on pull request #19073: URL: https://github.com/apache/flink/pull/19073#issuecomment-1067897329
> For another point, should we also unify the uid format compared to the 1.13? In all the versions, the writer always have the same uid with the sink transformation, thus there should be no problem. But for the other two operators: > > 1. For the committer operator, <= 1.13 it is set to `Sink Committer: <sink uid>` (https://github.com/apache/flink/blob/98c20ced2d5e514a967feedbc51c1570c22c91be/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/SinkTransformationTranslator.java#L247 > ) and on 1.15 it is set to `Sink <sink uid> Committer` (https://github.com/apache/flink/blob/a0d31c5e0914d8e759917a72ca7b667d3db2f1d2/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/SinkTransformationTranslator.java#L334 > ) > 2. For the global committer, it seems the 1.13 and 1.14 already have different format. But currently the usage of global committer is rare, thus I think we may keep it the same with 1.14 and then we do not to do any change. > > Thus as a whole, perhaps we change the uid format of committer back to `Sink Committer: <sink uid>`? Good catch, I think you are right we can make the life of our users a bit easier since there is not committer with 1.14, we can switch to using the uid pattern from 1.13 for the committer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
