fapaul commented on a change in pull request #19073:
URL: https://github.com/apache/flink/pull/19073#discussion_r827753056



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/SinkTransformationTranslator.java
##########
@@ -268,6 +277,26 @@ private void expand() {
                                     + " has set uid for some operators.");
                 }
 
+                // Set the operator uid hashes to support stateful upgrades 
without prior uids
+                if (hasWriterUidHash) {
+                    if (subTransformation.getName().equals(WRITER_NAME)) {

Review comment:
       I guess this can cause problems if other transformations use the same 
name. For the Writer and Committer there might be another way to set the 
properties but I currently do not see a way to change it for the 
GlobalCommitter because it is added as part of a post commit topology and the 
content of the topology is not accessible from the translator so I have to rely 
on the naming either way.
   
   Any ideas?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to